Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change api to support Lisk SDK v5 - Closes #3288 #3444

Merged
merged 473 commits into from
Apr 16, 2021
Merged

Change api to support Lisk SDK v5 - Closes #3288 #3444

merged 473 commits into from
Apr 16, 2021

Conversation

UsamaHameed
Copy link
Contributor

What was the problem?

This PR resolves #3288

How was it solved?

This PR merges all the changes incremently introduced to support lisk sdk v5.

How was it tested?

Unit and e2e tests

@UsamaHameed UsamaHameed self-assigned this Mar 23, 2021
iris salcedo and others added 29 commits April 1, 2021 12:50
Update test transaction constant
6f953f9
@UsamaHameed
limit search results to 100 to comply with api requirements
b8573e7
Update /utils/api mock data
a9d8e74
Mock constants
0ad2225
Update address and publicKey
d959b77
Update avatarWithNameandAddress
b24f03e
Update confirmMessage
9ce1df5
Mock account middleware actions
ff80516
Update login screen test
0af836e
Update balanceTable test
50e397a
Update searchBar/transactions
60e51c5
@reyraa
Add descriptions to the default values
3a23cc4
@reyraa
Merge branch '3452-fix-broken-ui' of github.com:LiskHQ/lisk-desktop i…
69ca2ba 
…nto 3452-fix-broken-ui
Merge pull request #3457 from LiskHQ/3452-fix-broken-ui
5de02e3
@UsamaHameed
fix transaction broadcast
fe0c866
@reyraa
Update list of txs based on number of confirmed tx
08d1932
@reyraa
Remove unused module imports
0fc1b23
@reyraa
Fix eslint max length
4161a78
@reyraa
Remove empty lines
50456c7
@reyraa
Display hyphen if rank not available
217f46e
@UsamaHameed
add toJSON to prototype of Bigint
3937466
@UsamaHameed
fix broadcast
9592388
@UsamaHameed
remove eslint ignore rule
3f14f51
@UsamaHameed
separate out cryptographic functions better
28ef77a
@UsamaHameed
update other occurances
4495b11
@UsamaHameed
fix addNewPendingTransaction action
3414711
@UsamaHameed
fix issues with confirming pending transactions
a0094e6
@UsamaHameed
make getAccounts call properly
e60b692
@UsamaHameed
fix votes api call
6277f8e
reyraa and others added 23 commits April 14, 2021 16:19
@reyraa
Remove e2e tests temporarily
0b7f264
Fix networkSelector validation
d20bac4
@UsamaHameed
fix electron build output name
65ca867
Code cleanup
9995e27
Fix login screen crash
c94b986
Fix redirect
9c01889
Store network settings
56563b1
Merge remote-tracking branch 'origin/3453-fix-unit-tests' into 3475-r…
da5781e 
…efactor-network-switcher
Update unit test
3fd0288
Use alias import
2e98035
@UsamaHameed @reyraa
fix electron build output name
a42d09e
@reyraa
Merge pull request #3463 from LiskHQ/3453-fix-unit-tests
9e69635 
Fix unit tests - #3453
@reyraa
Merge pull request #3479 from LiskHQ/3475-refactor-network-switcher
b83898b 
Enable users to enter Lisk Service URL in network switcher - Closes #3475
@reyraa
Bump version 2.0.0-alpha.6
00fc632
@UsamaHameed
Merge remote-tracking branch 'refs/remotes/origin/development'
b1298a0
@UsamaHameed
ignore test coverage temporarily
558e5aa
@UsamaHameed
fix imports and skip test
347651f
@UsamaHameed
fix deepscan issues
155838b
@UsamaHameed
hopefully fix percy config
d6b2143
@UsamaHameed
fix deepscan issues
e64550d
@UsamaHameed
remove express external from webpack base config
6e38b75
@UsamaHameed
make null check for external links better
5d20afb
@UsamaHameed
remove percy stage temporarily
a37dce8
@UsamaHameed UsamaHameed requested review from reyraa and isalga April 15, 2021 11:36
@reyraa reyraa merged commit 6faaba1 into development Apr 16, 2021
@reyraa reyraa deleted the feature-sdk-v5 branch April 16, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isalga isalga isalga approved these changes

@reyraa reyraa reyraa approved these changes

Assignees

@UsamaHameed UsamaHameed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change API to support Lisk SDK v5 API
3 participants
@UsamaHameed @reyraa @isalga